On Thu, 11 Jan 2024 at 10:50, Jonathan Wakely <jwak...@redhat.com> wrote:
> On Thu, 11 Jan 2024 at 10:12, Ken Matsui <kmat...@cs.washington.edu> wrote:
> >
> > On Thu, 11 Jan 2024 at 09:55, Jonathan Wakely <jwakely....@gmail.com> wrote:
> > > On Thu, 11 Jan 2024, 09:43 Ken Matsui, <[1]kmat...@gcc.gnu.org> wrote:
> > >
> > > > libstdc++-v3/ChangeLog:
> > >
> > > > * src/filesystem/ops-common.h (stat_type): Use using.
> > >
> > > > Signed-off-by: Ken Matsui <[2]kmat...@gcc.gnu.org>
> > > > ---
> > > > libstdc++-v3/src/filesystem/ops-common.h | 4 ++--
> > > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > > diff --git a/libstdc++-v3/src/filesystem/ops-common.h
> > > > b/libstdc++-v3/src/filesystem/ops-common.h
> > > > index d78a54754c2..e302d8caae6 100644
> > > > --- a/libstdc++-v3/src/filesystem/ops-common.h
> > > > +++ b/libstdc++-v3/src/filesystem/ops-common.h
> > > > @@ -118,7 +118,7 @@ namespace __gnu_posix
> > > > inline int close(int fd)
> > > > { return ::_close(fd); }
> > >
> > > > - typedef struct ::__stat64 stat_type;
> > > > + using stat_type = struct ::_stat64;
> > >
> > > You've removed an underscore, is that intentional? Has this been
> > > compiled
> > > + tested with mingw?
> > This is totally unintentional. I'll fix it. I've tested it with Linux
> > and do not have a mingw environment to test it with. Would you have any
> > suggestions on how to test it?
>
> If your linux distro has prebuilt packages for mingw-w64-g++ then it's
> pretty easy to build a new compiler from trunk. I can give you a
> simple recipe for doing it on Fedora.
>
> In the meanwhile, I can test your updated patch for you.
>
I am using Ubuntu and was able to install mingw-w64-g++ with apt. I
tried the following command to test the patch:
make check-target-libstdc++-v3 ALT_CXX_UNDER_TEST="$(which
x86_64-w64-mingw32-g++)" RUNTESTFLAGS='conformance.exp=filesystem/*'
But it looks like the test is not using the mingw compiler. Also,
when we want to test to build GCC with a different compiler, do we
need to rebuild the whole GCC again (i.e., make clean && export CXX=...
&& make)?
I really appreciate your recipe if it also works for Ubuntu. Thank you!
--
Ken Matsui
