If the fixes remove the failures on AIX, then the patch to disable the tests also can be reverted.
Thanks, David On Wed, Jan 17, 2024 at 8:06 PM Alexandre Oliva <ol...@adacore.com> wrote: > David, > > On Jan 7, 2024, "Kewen.Lin" <li...@linux.ibm.com> wrote: > > > As PR113100 shows, the unbiasing introduced by r14-6737 can > > cause the scrubbing to overrun and screw some critical data > > on stack like saved toc base consequently cause segfault on > > Power. > > I suppose this problem that Kewen fixed (thanks) was what caused you to > install commit r14-6838. According to posted test results, strub worked > on AIX until Dec 20, when the fixes for sparc that broke strub on ppc > went in. > > I can't seem to find the email in which you posted the patch, and I'd > have appreciated if you'd copied me. I wouldn't have missed it for so > long if you had. Since I couldn't find that patch, I'm responding in > this thread instead. > > The r14-6838 patch is actually very very broken. Disabling strub on a > target is not a matter of changing only the testsuite. Your additions > to the tests even broke the strub-unsupported testcases, that tested > exactly the feature that enables ports to disable strub in a way that > informs users in case they attempt to use it. > > I'd thus like to revert that patch. > > Kewen's patch needs a little additional cleanup, that I'm preparing now, > to restore fully-functioning strub on sparc32. > > Please let me know in case you observe any other problems related with > strub. I'd be happy to fix them, but I can only do so once I'm aware of > them. > > In case the reversal or the upcoming cleanup has any negative impact, > please make sure you let me know. > > Thanks, > > Happy GNU Year! > > -- > Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ > Free Software Activist GNU Toolchain Engineer > More tolerance and less prejudice are key for inclusion and diversity > Excluding neuro-others for not behaving ""normal"" is *not* inclusive >
