On Fri, 19 Jan 2024 at 08:41, Nathaniel Shead <nathanielosh...@gmail.com> wrote: > > Tested on x86_64-pc-linux-gnu using a cross-compiler to > arm-unknown-linux-gnueabihf with --enable-threads=0 that the link test > is correctly skipped. OK for trunk? > > -- >8 -- > > This disables the new test added by r14-8168 on machines that don't have > TLS support, such as bare-metal ARM. > > gcc/testsuite/ChangeLog: > > * g++.dg/modules/pr113292_c.C: Require TLS. > > Signed-off-by: Nathaniel Shead <nathanielosh...@gmail.com> > --- > gcc/testsuite/g++.dg/modules/pr113292_c.C | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/gcc/testsuite/g++.dg/modules/pr113292_c.C > b/gcc/testsuite/g++.dg/modules/pr113292_c.C > index aa3f32ae818..c117c7cfcd4 100644 > --- a/gcc/testsuite/g++.dg/modules/pr113292_c.C > +++ b/gcc/testsuite/g++.dg/modules/pr113292_c.C > @@ -1,6 +1,8 @@ > // PR c++/113292 > // { dg-module-do link } > +// { dg-add-options tls } > // { dg-additional-options "-fmodules-ts" } > +// { dg-require-effective-target tls_runtime } > Hi,
Thanks, I think this is OK, although I think we prefer to put dg-require before dg-add-options (after dg-module-do). Christophe > import "pr113292_a.H"; > > -- > 2.43.0 >