On Mon, Jan 29, 2024 at 9:00 AM Jakub Jelinek <ja...@redhat.com> wrote: > > On Mon, Jan 29, 2024 at 08:45:45AM -0800, H.J. Lu wrote: > > In this case, these are internal to the same comdat group: > > But that is only by accident, no?
This may be by luck. I don't know if gcc checks it when generating such references. > I mean, if you need to refer to such a symbol from > non-comdat function or comdat function in a different comdat group > and RA decides it wants the constant in memory rather than code? > Your patch uses > if (decl) > return targetm.asm_out.function_rodata_section (decl, ???); > and default_function_rodata_section only looks at comdat group of the > passed in decl. But the decl here is what the constant refers to, not > who is referring it. > > Jakub > -- H.J.
