Hello, Christophe, Thanks for the patch.
On Feb 5, 2024, Christophe Lyon <christophe.l...@linaro.org> wrote: > In order to save build time, our CI overrides BUILD_INFO="", which > works when invoking 'make all' but not for 'make install' in case some > info files need an update. Hmm, I don't think this would be desirable. We ship updated info files in release tarballs, and it would be desirable to install them even if makeinfo is not available in the build environment. > I noticed this when testing a patch posted on the gcc-patches list, > leading to an error at 'make install' time after updating tm.texi (the > build reported 'new text' in tm.texi and stopped). This is because > 'install' depends on 'install-info', which depends on > $(DESTDIR)$(infodir)/gccint.info (among others). Ideally, we'd detect and report info files that are out-of-date WRT their ultimate sources, especially to catch tm.texi.in changes, but doing so only at install time is clearly suboptimal. I mean, if we don't have the tools to build info files, it's fine if we skip their building, and even refrain from installing info files that are missing or outdated, but we should install prebuilt ones if they're available, and we should probably *not* refrain from trying to satisfy the dependencies for info files at build time, even if it turns out that we can't build the info files themselves. This suggests to me that, rather than setting BUILD_INFO to the empty string, we should set it to e.g. no-info, so that $(MAKEINFO) will not be run because x$(BUILD_INFO) != xinfo, but so that we still get the dependencies resolved, e.g. by making no-info depend on info. Or maybe make it info-check-deps, and insert that between info and its current deps. WDYT? -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Disinformation flourishes because many people care deeply about injustice but very few check the facts. Think Assange & Stallman. The empires strike back
