Dimitrios Apostolou <[email protected]> writes:
> Hi Dodji,
>
> On Mon, 4 Jun 2012, Dodji Seketeli wrote:
>
>> Hello Dimitrios,
>>
>> I cannot approve or deny your patch, but I have one question.
>>
>
> Who should I CC then?
Do not worry, I am CC-ing the maintainers. I just forgot to CC them
when I replied. Sorry for that.
> I saw that you have commits in that file.
Yeah, nobody is perfect. :-)
>> I am wondering why this change implies better performance.
>>
>> Is this because when we later want to encode a new line/column, and
>> hit the spot below, (in linemap_line_start via
>> linemap_position_for_column), we call less linemap_add (and thus
>> allocate less maps):
>
> Almost. To be exact we don't even enter linemap_line_start() because
> of the check in linemap_position_for_column().
Great. So, for what it is worth, the patch looks OK to me.
Let's see what the maintainers say.
Thank you.
--
Dodji
