On Sat, Feb 17, 2024 at 09:59:12PM +0200, Dimitar Dimitrov wrote:
> On Fri, Feb 16, 2024 at 07:06:57PM +0100, Jakub Jelinek wrote:
> > On Fri, Feb 16, 2024 at 07:52:17PM +0200, Dimitar Dimitrov wrote:
> > > The issue in PR112344 is triggered only at -O2, so there is little value
> > > in running the test at lower optimization levels.  At the same time the
> > 
> > That is generally not true.
> > We had hundreds of cases in the history where a test written for one bug
> > let us discover a different bug later on, often at different optimization
> > level etc.
> > 
> > If the test is too slow, perhaps the dg-skip-if should take the
> > run_expensive_tests effective target into account, like:
> > /* { dg-skip-if "" { ! run_expensive_tests }  { "*" } { "-O0" "-O1" } } */
> 
> Thank you, this is reasonable.  I'll send V2 with that change.
> 
> Curiously, -Os also needs to be added to the slow variants, along with
> -O0 and -O1.

Ok then.

> > But guess another question is if the bug can be reproduced with fewer
> > iterations...
> 
> I could not think of a way to do it.

Yeah, I haven't managed to reduce the number of iterations and still trigger
the bug.

        Jakub

Reply via email to