Hello Andrew, Thank you for the review!
Renaming functions and comments that reference functions with the i386_ prefix can trigger extensive changes. This task should ideally be handled in a separate follow-up patch. The primary goal of the renaming changes in https://gcc.gnu.org/pipermail/gcc-patches/attachments/20240221/8f41fb9a/attachment-0001.txt was to avoid direct references from the aarch64 target to functions with i386_ prefix. Regards, Evgeny -----Original Message----- Wednesday, February 21, 2024 7:50 PM Andrew Pinski wrote: On Wed, Feb 21, 2024 at 10:38 AM Evgeny Karpov <evgeny.kar...@microsoft.com> wrote: > > In config/i386/winnt.cc there are many x86_64 comments and many function names that use i386 in them? When moving it seems like better to rename them and remove references to 86. I don't see any changes that rename the functions or comments there. Thanks, Andrew