On Tue, Feb 27, 2024 at 09:51:05AM +0100, Richard Biener wrote:
> On Tue, 27 Feb 2024, Jakub Jelinek wrote:
>
> > On Tue, Feb 27, 2024 at 09:35:43AM +0100, Richard Biener wrote:
> > > I do wonder whether we can handle the missing LHS case generically
> > > in the direct optab expander for fns that are PURE or CONST?
> >
> > Maybe the 2 operand expand_internal_call could do it before handing over
> > to individual expanders. Can that wait for stage1?
>
> Sure, unless you think this is a better fix at this stage (not doing
> the constant folding).
The constant folding is there for the case where there is a lhs.
So, if expand_internal_call gets added NULL lhs handling,
expand_bitquery could just remove it, but the rest would stay.
And for other ifns, there is no known issue with the NULL lhs, so that
would be just an cleanup with some risks.
Jakub
