Ping
On 2/19/2024 10:11 AM, Saurabh Jha wrote:
On 2/9/2024 2:57 PM, Richard Earnshaw (lists) wrote:
On 30/01/2024 17:07, Saurabh Jha wrote:
Hey,
Previously, this test was added to fix this bug:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112337. However, it did
not check the compilation options before using them, leading to errors.
This patch fixes the test by first checking whether it can use the
options before using them.
Tested for arm-none-eabi and found no regressions. The output of
check-gcc with RUNTESTFLAGS="arm.exp=*" changed like this:
Before:
# of expected passes 5963
# of unexpected failures 64
After:
# of expected passes 5964
# of unexpected failures 63
Ok for master?
Regards,
Saurabh
gcc/testsuite/ChangeLog:
* gcc.target/arm/pr112337.c: Check whether we can use the
compilation options before using them.
My apologies for missing this earlier. It didn't show up in
patchwork. That's most likely because the attachment is a binary blob
instead of text/plain. That also means that the Linaro CI system
hasn't seen this patch either. Please can you fix your mailer to add
plain text patch files.
-/* { dg-options "-O2 -march=armv8.1-m.main+fp.dp+mve.fp
-mfloat-abi=hard" } */
+/* { dg-require-effective-target arm_hard_ok } */
+/* { dg-require-effective-target arm_v8_1m_mve_ok } */
+/* { dg-options "-O2 -mfloat-abi=hard" } */
+/* { dg-add-options arm_v8_1m_mve } */
This is moving in the right direction, but it adds more than
necessary now: checking for, and adding -mfloat-abi=hard is not
necessary any more as arm_v8_1m_mve_ok will work out what float-abi
flags are needed to make the options work. (What's more, it will
prevent the test from running if the base configuration of the
compiler is incompatible with the hard float ABI, which is more than
we need.).
So please can you re-spin removing the hard-float check and removing
that from dg-options.
Thanks,
R.
Hi Richard,
Agreed with your comments. Please find the patch with the suggested
changes attached.
Regards,
Saurabh
