On Thu, Jun 7, 2012 at 12:05 AM, <davi...@google.com> wrote: > other than the update issue, good for google branch. > > David > > > http://codereview.appspot.com/6282045/diff/4003/libgcc/libgcov.c > File libgcc/libgcov.c (right): > > http://codereview.appspot.com/6282045/diff/4003/libgcc/libgcov.c#newcode1127 > libgcc/libgcov.c:1127: cs_prg->num_hot_counters = > cs_tprg->num_hot_counters; > Should the update be outside the if (!cs_prg->runs++)
You are right - with the change I made to take the max it should be outside the if. Fixed, retested and committed to google/main. Backport to google 4_7 and 4_6 going in shortly. Thanks, Teresa > > http://codereview.appspot.com/6282045/ -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413