Re: [PATCH] ipa: Avoid duplicate replacements in IPA-SRA transformation phase

[Jakub Jelinek]

On Fri, Mar 15, 2024 at 06:57:18PM +0100, Martin Jambor wrote:
> --- a/gcc/ipa-param-manipulation.cc
> +++ b/gcc/ipa-param-manipulation.cc
> @@ -1525,6 +1525,22 @@ ipa_param_body_adjustments::common_initialization 
> (tree old_fndecl,
>                    replacement with a constant (for split aggregates passed
>                    by value).  */
>  
> +               if (split[parm_num])
> +                 {
> +                   /* We must be careful not to add a duplicate
> +                      replacement. */
> +                   sort_replacements ();
> +                   ipa_param_body_replacement *pbr =
> +                     lookup_replacement_1 (m_oparms[parm_num],
> +                                           av.unit_offset);

Formatting nit, the = should be on the next line before
lookup_replacement_1.
                      ipa_param_body_replacement *pbr
                        = lookup_replacement_1 (m_oparms[parm_num],
                                                av.unit_offset);

        Jakub