On 3/22/24 07:22, Palmer Dabbelt wrote:
On Thu, 21 Mar 2024 10:00:24 PDT (-0700), Patrick O'Neill wrote:
Use dg_add_options riscv_a to add atomic extension when running compile
tests on non-a targets.

gcc/testsuite/ChangeLog:

    * gcc.target/riscv/amo-table-ztso-amo-add-1.c: Add
      dg_add_options riscv_a
    * gcc.target/riscv/amo-table-ztso-amo-add-2.c: Ditto.
    * gcc.target/riscv/amo-table-ztso-amo-add-3.c: Ditto.
    * gcc.target/riscv/amo-table-ztso-amo-add-4.c: Ditto.
    * gcc.target/riscv/amo-table-ztso-amo-add-5.c: Ditto.
    * gcc.target/riscv/amo-table-ztso-compare-exchange-1.c: Ditto.
    * gcc.target/riscv/amo-table-ztso-compare-exchange-2.c: Ditto.
    * gcc.target/riscv/amo-table-ztso-compare-exchange-3.c: Ditto.
    * gcc.target/riscv/amo-table-ztso-compare-exchange-4.c: Ditto.
    * gcc.target/riscv/amo-table-ztso-compare-exchange-5.c: Ditto.
    * gcc.target/riscv/amo-table-ztso-compare-exchange-6.c: Ditto.
    * gcc.target/riscv/amo-table-ztso-compare-exchange-7.c: Ditto.
    * gcc.target/riscv/amo-table-ztso-subword-amo-add-1.c: Ditto.
    * gcc.target/riscv/amo-table-ztso-subword-amo-add-2.c: Ditto.
    * gcc.target/riscv/amo-table-ztso-subword-amo-add-3.c: Ditto.
    * gcc.target/riscv/amo-table-ztso-subword-amo-add-4.c: Ditto.
    * gcc.target/riscv/amo-table-ztso-subword-amo-add-5.c: Ditto.

Signed-off-by: Patrick O'Neill <patr...@rivosinc.com>

Presumably these trip up on the non-A targets that Edwin's just adding to the
testers?  They'd also trip up anyone running newlib/mulilib tests.

Either way they look right to me, so

Reviewed-by: Palmer Dabbelt <pal...@rivosinc.com>
Acked-by: Palmer Dabbelt <pal...@rivosinc.com>

Thanks!

Committed - Thanks!

And yes, this was in response to the rv32/64imc_* targets that Edwin was adding to ci.

Patrick

Reply via email to