On 3/22/24 12:24 PM, Jakub Jelinek wrote:
On Fri, Mar 22, 2024 at 12:17:03PM -0600, Jeff Law wrote:
I'd just make target_lra return false for nvptx rather than creating a new

The lra effective target currently though doesn't check if asm goto can have
outputs, but rather if the target is using lra.
Right. It's not 100% precise as we lose one testcase for nvptx. THat's a tradeoff I'd be willing to make.


selector -- I'm not aware of any features other than asm goto that LRA
provides that aren't supported reload.

Or perhaps rename the selector entirely to target_asm_goto?

In that case we should just test if asm goto with outputs is allowed
in a cached snippet, rather than testing if there is LRA in the ra dumps.
I won't lose any sleep with that approach, I just don't see that it adds a lot of value.

jeff

Reply via email to