On Mon, 2012-06-11 at 18:24 -0700, David Daney wrote: > > This patch addes the -mno-synci flag to MIPS tests that specify an > > architecture that does not support synci, thus getting rid of the > > warning message and making the tests pass. Tested with the mips-linux-gnu > > and mips-sde-elf targets both with and without --with-synci on the > > GCC configuration. > > > > OK to checkin? > > I wonder if it would make more sense to modify the testsuite driver to > take care of this. It seems like the set of files with the -mno-synci > annotation could easily become different than the set that requires it. > > David Daney
I did think about that, but the number of flags that I would have to check for in the testsuite driver to decide whether or not to turn on -mno-synci was large enough to make me not want to do it that way. I would need to check the isa= and isa_rev= flags that are currently handled in the driver, the -mabi flag, the -march flag, and the -mips flag. The number of values that each flag could have (particularly -march) is rather large. I can imagine people adding a new test and forgetting to add -mno-synci but that would be easy to fix and no worse then adding a new -march value and not handling it in the test suite driver. Steve Ellcey sell...@mips.com