On 5/1/24 04:37, Nathaniel Shead wrote:
Bootstrapped and regtested on x86_64-pc-linux-gnu, OK for trunk?
-- >8 --
This patch implements the changes described in
https://github.com/itanium-cxx-abi/cxx-abi/pull/171.
One restriction that is lifted in the ABI that hasn't been updated here
is that the ABI no longer requires unique vtables to be emitted with
vague linkage. I haven't changed this behaviour for this patch, but in
the future we should probably look into changing the relevant target
hook ('class_data_always_comdat') to default to 'false'.
I suppose we could, but it seems unnecessary. We've previously decided
to use COMDAT even when we know that a vague linkage entity is only
emitted in one TU. For instance, sticking with COMDAT is more forgiving
to changes in key function identification.
The patch is OK.
Jason
