Evgeny Karpov <evgeny.kar...@microsoft.com> writes: > This patch renames functions related to dllimport/dllexport > and selectany functionality. These functions will be reused > in the aarch64-w64-mingw32 target. > > gcc/ChangeLog: > > * config/i386/cygming.h (mingw_pe_record_stub): > Rename functions in mingw folder which will be reused for > aarch64. > (TARGET_ASM_FILE_END): Update to new target-independent name. > (SUBTARGET_ATTRIBUTE_TABLE): Likewise. > (TARGET_VALID_DLLIMPORT_ATTRIBUTE_P): Likewise. > (SUB_TARGET_RECORD_STUB): Likewise. > * config/i386/i386-protos.h (ix86_handle_selectany_attribute): Likewise. > (mingw_handle_selectany_attribute): Likewise. > (i386_pe_valid_dllimport_attribute_p): Likewise. > (mingw_pe_valid_dllimport_attribute_p): Likewise. > (i386_pe_file_end): Likewise. > (mingw_pe_file_end): Likewise. > (i386_pe_record_stub): Likewise. > (mingw_pe_record_stub): Likewise. > * config/mingw/winnt.cc (ix86_handle_selectany_attribute): Likewise. > (mingw_handle_selectany_attribute): Likewise. > (i386_pe_valid_dllimport_attribute_p): Likewise. > (mingw_pe_valid_dllimport_attribute_p): Likewise. > (i386_pe_record_stub): Likewise. > (mingw_pe_record_stub): Likewise. > (i386_pe_file_end): Likewise. > (mingw_pe_file_end): Likewise. > * config/mingw/winnt.h (mingw_handle_selectany_attribute): > Declate functionality that will be reused by multiple targets. > (mingw_pe_file_end): Likewise. > (mingw_pe_record_stub): Likewise. > (mingw_pe_valid_dllimport_attribute_p): Likewise.
Ok, but... > [...] > diff --git a/gcc/config/mingw/winnt.cc b/gcc/config/mingw/winnt.cc > index 9901576ade0..a0b5950be2e 100644 > --- a/gcc/config/mingw/winnt.cc > +++ b/gcc/config/mingw/winnt.cc > @@ -71,7 +71,7 @@ ix86_handle_shared_attribute (tree *node, tree name, tree, > int, > /* Handle a "selectany" attribute; > arguments as in struct attribute_spec.handler. */ > tree > -ix86_handle_selectany_attribute (tree *node, tree name, tree, int, > +mingw_handle_selectany_attribute (tree *node, tree name, tree, int, > bool *no_add_attrs) please reindent the parameters for the new name length. Thanks, Richard
