Hi Jeff, subject typo: s/reuire/require/
on 2024/5/23 09:11, Jiufu Guo wrote: > Hi, > > Case pr106550.c is testing constant building for 64bit > register. So, this case requires target of has_arch_ppc64. > Nit: Maybe add more comments saying it fails with -m32 without having the expected rldimi? So it requires has_arch_ppc64. > Bootstrap and regtest pass on ppc64{,le}. > Is this ok for trunk? > Missing a changelog entry here, maybe something like: gcc/testsuite/ChangeLog: * gcc.target/powerpc/pr106550.c: Adjust by requiring has_arch_ppc64 effective target. > BR, > Jeff(Jiufu) Guo > > --- > gcc/testsuite/gcc.target/powerpc/pr106550.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/gcc/testsuite/gcc.target/powerpc/pr106550.c > b/gcc/testsuite/gcc.target/powerpc/pr106550.c > index 74e395331ab..146514b3adf 100644 > --- a/gcc/testsuite/gcc.target/powerpc/pr106550.c > +++ b/gcc/testsuite/gcc.target/powerpc/pr106550.c > @@ -1,6 +1,7 @@ > /* PR target/106550 */ > /* { dg-options "-O2 -mdejagnu-cpu=power10" } */ > /* { dg-require-effective-target power10_ok } */ Nit: power10_ok can be dropped. > +/* { dg-require-effective-target has_arch_ppc64 } */ OK with the nits above tweaked, thanks. BR, Kewen