Hi Haochen, on 2024/5/27 15:22, HAO CHEN GUI wrote: > Hi Kewen, > Thanks for your comments. > > 在 2024/5/27 11:18, Kewen.Lin 写道: >> Does this require "This pattern is not allowed to FAIL."? >> >> I guess yes? Since if it's decided to go with this pattern >> expanding, there is no fall back? > > The builtin is inline folded if the optab doesn't exist on > the target. Otherwise, it is expanded by target specific > insns. If it fails at expand, the library is called. It can't > fall back to inline folding when it fails at expand. I am not > sure whether it should be marked "allowed to FAIL" or not.
Ah, so it's allowed to FAIL, just not falling back with the generic folding way, then it should not be marked with "not allowed to FAIL" clearly. Maybe we can note that "FAIL" makes it call the according library function instead (avoiding the possible assumption it will fall back with generic folding). BR, Kewen > > Could anyone advice me? > > Thanks > Gui Haochen
