On Thu, May 30, 2024 at 12:48 AM Martin Uecker <uec...@tugraz.at> wrote: > > > Hi Ian, > > can you give me a green light for the go changes. The C FE > changes were approved. > > The only change with respect to the last version are > the removal of the unneeded null check for the > main variant (as discussed) and that I also removed the > > container->decls_seen.add (TREE_TYPE (decl)); > > and the corresponding check, because I think it is > redundant if we also test for the main variant. > (it wasn't with TYPE_CANONICAL because this was > only added conditionally). > > The other code in the file only checks for added > declarations not types, so should not depend on this.
Apologies. I thought that I had already said that the Go changes are fine if the libgo tests still pass. Anyhow, that is the case: if the tests pass, the change is fine. Thanks. Ian
