Segher Boessenkool <seg...@kernel.crashing.org> writes: > Hi! > > On Fri, May 31, 2024 at 01:21:44AM +0530, Ajit Agarwal wrote: >> Code is implemented with pure virtual functions to interface with target >> code. > > It's not a pure function. A pure function -- by definition -- has no > side effects. These things have side effects. > > What you mean is this is *an implementation* for C++ functions without > a generic implementation. An obfuscation some people (like me) would > say. But please call things what they are! So not "pure function". > That has a meaning, and this isn't it.
"pure virtual function" is an established term. The "pure" modifies "virtual", not "function". The description is correct because the patch adds pure virtual functions to the base class and expects the derived class to override and implement them. >> * config/aarch64/aarch64-ldp-fusion.cc: Add target specific >> implementation of additional virtual functions added in pair_fusion >> struct. > > This does not belong in this patch. Do not send "rs6000" patches that > touch anything outside of config/rs6000/ and similar, certainly not in > config/something-else/! > > This would be WAY easier to review (read: AT ALL POSSIBLE) if you > included some detailed rationale and design document. Please don't shout. I don't think this kind of aggressive review is helpful to the project. Richard
