On 6/4/24 05:47, Simon Martin wrote:
Hi Jason,

Thanks for the review.

On 31 May 2024, at 22:45, Jason Merrill wrote:

On 5/30/24 07:31, Simon Martin wrote:
We currently fail upon the following because an assert in
dependent_type_p
fails for f's parameter

=== cut here ===
consteval int id (int i) { return i; }
constexpr int
f (auto i) requires requires { id (i) } { return i; }
void g () { f (42); }
=== cut here ===

This patch fixes this by handling synthesized parameters for
abbreviated
function templates in that assert.

I don't see why implicit template parameters should be handled
differently from explicit ones here.

This seems more like an error-recovery issue, and I'd be open to
adding || seen_error() to that assert like in various others.

Makes sense; this is what the attached updated patch (successfully
tested on x86_64-pc-linux-gnu) does.

Is it better and OK for trunk?

OK.

Jason

Reply via email to