On 6/5/24 00:45, Andi Kleen wrote:
The only semantics changes are slightly more vague error messages
to generalize.
Just a few nits:
+/* Extracting strings from constexpr. */
+
+class cexpr_str
+{
+public:
+ cexpr_str (tree message) : message(message) {}
Space before paren.
...
+/* Get constant string from MESSAGE at LOCATION. Returns
+ true if successfull, otherwise false. */
This comment needs updating for the interface change. Only one 'l' in
"successful".
-void
-finish_static_assert (tree condition, tree message, location_t location,
- bool member_p, bool show_expr_p)
...
+
+/* Extract constant string at LOCATION into output string MSG without LEN.
+ Returns true if successfull, otherwise false. */
"successful" again.
OK with these adjustments.
Jason
