Hi Harald, thank you very much for the review. Committed as:
gcc-15-1369-gdb75a6657e9 Regarding your question on the coarray-tests that are not in the coarray-directory: These test in most cases test only one method of implementing coarrays. I.e., they are either testing just -fcoarray=single or -fcoarray=lib -lcaf_single, which are two different approaches. The tests in the coarray-directory test all available methods to implement coarrays. Pushing all coarray-tests into the coarray-directory will fail a lot of them, because the behavior of -fcoarray=single and -fcoarray=lib -lcaf_single is different in some corner cases. That's why the coarray-tests in the main gfortran-dir are separate. I do understand why it may be confusing, but I don't see an easy solution. Does this answer your question? Thanks again for the review. Regards, Andre On Fri, 14 Jun 2024 21:43:47 +0200 Harald Anlauf <anl...@gmx.de> wrote: > Hi Andre, > > the patch looks fairly simple and obvious, so OK from my side. > > *** > > Regarding the testsuite: since you renamed one of the testcases > gfortran.dg/coarray_alloc_comp_* and moved it to gfortran.dg/coarray/, > I checked and noticed that there are other similar runtime tests for > coarrays (while some are compile-time only tests). > > Do we plan to "clean" this up and move more/all related runtime > tests to the coarray/ subdirectory? What is the general opinion on > this? > > *** > > Thanks for the patch! > > Harald > > > Am 14.06.24 um 09:22 schrieb Andre Vehreschild: > > Hi all, > > > > I messed up renaming of the coarray_alloc_comp-test. This is fixed in the > > second version of the patch. Sorry for the inconvenience. > > > > Additionally I figured that this patch also fixed PR fortran/103112. > > > > Regtests ok on x86_64 Fedora 39. Ok for mainline? > > > > Regards, > > Andre > > > > On Tue, 11 Jun 2024 16:12:38 +0200 > > Andre Vehreschild <ve...@gmx.de> wrote: > > > >> Hi all, > >> > >> attached patch has already been present in 2020, but lost my attention. It > >> fixes an ICE in the testsuite. The old mails description is: > >> > >> attached patch fixes PR96418 where the code in the testsuite when compiled > >> with -fcoarray=single lead to an ICE. The reason was that the coarray > >> object was derefed as an array, but it was no array. Introducing the test > >> for the descriptor removes the ICE. > >> > >> Regtests ok on x86_64-linux/Fedora 39. Ok for mainline? > >> > >> Regards, > >> Andre > >> -- > >> Andre Vehreschild * Email: vehre ad gmx dot de > > > > > > -- > > Andre Vehreschild * Email: vehre ad gmx dot de > -- Andre Vehreschild * Email: vehre ad gmx dot de