on 2024/6/15 13:00, Gaius Mulley wrote:
> "Kewen.Lin" <li...@linux.ibm.com> writes:
>
>> Hi Gaius,
>>
>>>> static tree
>>>> build_m2_short_real_node (void)
>>>> {
>>>> - tree c;
>>>> -
>>>> - /* Define `REAL'. */
>>>> -
>>>> - c = make_node (REAL_TYPE);
>>>> - TYPE_PRECISION (c) = FLOAT_TYPE_SIZE;
>>>> - layout_type (c);
>>>> - return c;
>>>> + /* Define `SHORTREAL'. */
>>>> + layout_type (float_type_node);
>>>
>>> It looks that float_type_node, double_type_node, float128_type_node and
>>> long_double_type_node have been called with layout_type when they are
>>> being initialized in function build_common_tree_nodes, maybe we can just
>>> assert their TYPE_SIZE.
>>
>> I just noticed that latest trunk still has {FLOAT,{,LONG_}DOUBLE}_TYPE_SIZE
>> in gcc/m2 and realized that my comment above was misleading, sorry about
>> that.
>> It meant TYPE_SIZE (float_type_node) etc. instead of
>> {FLOAT,{,LONG_}DOUBLE}_TYPE_SIZE,
>> as this patch series would like to get rid of
>> {FLOAT,{,LONG_}DOUBLE}_TYPE_SIZE.
>>
>> I adjusted them as below patch, does this look good to you?
>
> Hi Kewen,
>
> ah yes indeed, lgtm,
Thanks Gaius! Pushed as r15-1362-g96fe23eb8a9eba.
BR,
Kewen
