YunQiang Su <s...@gcc.gnu.org> writes: > We check gcc_cv_as_mips_explicit_relocs if > gcc_cv_as_mips_explicit_relocs_pcrel > only, while gcc_cv_as_mips_explicit_relocs is used by later code. > > Maybe, it is time for use to set gcc_cv_as_mips_explicit_relocs always now, > as it has been in Binutils for more than 20 years.
Yeah, agreed FWIW. This was necessary while the feature was relatively new, and while we still supported IRIX as, but I can't see any reasonable justification for using such an ancient binutils with modern GCC. Getting rid of -mno-explicit-relocs altogether might simplify things. ichard > > gcc > * configure.ac: Set gcc_cv_as_mips_explicit_relocs if > gcc_cv_as_mips_explicit_relocs_pcrel. > * configure: Regenerate. > --- > gcc/configure | 2 ++ > gcc/configure.ac | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/gcc/configure b/gcc/configure > index 9dc0b65dfaa..ad998105da3 100755 > --- a/gcc/configure > +++ b/gcc/configure > @@ -30278,6 +30278,8 @@ $as_echo "#define MIPS_EXPLICIT_RELOCS > MIPS_EXPLICIT_RELOCS_BASE" >>confdefs.h > > fi > > + else > + gcc_cv_as_mips_explicit_relocs=yes > fi > > if test x$gcc_cv_as_mips_explicit_relocs = xno; then \ > diff --git a/gcc/configure.ac b/gcc/configure.ac > index b2243e9954a..c51d3ca5f1b 100644 > --- a/gcc/configure.ac > +++ b/gcc/configure.ac > @@ -5255,6 +5255,8 @@ LCF0: > [ lw $4,%gp_rel(foo)($4)],, > [AC_DEFINE(MIPS_EXPLICIT_RELOCS, MIPS_EXPLICIT_RELOCS_BASE, > [Define if assembler supports %reloc.])]) > + else > + gcc_cv_as_mips_explicit_relocs=yes > fi > > if test x$gcc_cv_as_mips_explicit_relocs = xno; then \
