On Fri, Jun 21, 2024 at 06:59:05PM +0200, Michal Jireš wrote: > > The lockfiles scare me a bit. What happens when they get lost, e.g. > > due to a compiler crash? You may need some recovery for that. > > Perhaps it would be better to make the files self checking, so that > > partial files can be detected when reading, and get rid of the locks. > > It uses process-associated locks via fcntl, so if the compiler crashes, > the locks will be released. If the compiler process crashes and leaves > partially written file, the lto-wrapper deletes it in tool_cleanup. > If a file is missing, the cache entry will be deleted.
Sounds good to me. -Andi