On Fri, Jun 7, 2024 at 2:45 AM Evgeny Karpov
<evgeny.kar...@microsoft.com> wrote:
>
> Hello,
>
> Thank you for reviewing v1!
> v2 addresses all comments on v1.
>
> Changes in v2:
> - Move winnt.h and winnt-dll.h to config.gcc.
> - Resolve the issue with GCC GC in winnt-dll.cc.
> - Add definitions for GOT_ALIAS_SET,
> PE_COFF_EXTERN_DECL_SHOULD_BE_LEGITIMIZED, and HAVE_64BIT_POINTERS to
> cygming.h.
> - Replace intermediate functions for PECOFF with ifdef checks in ix86.
> - Update the copyright date in winnt-dll.cc.
> - Correct the style.
> - Rebase from 7th June 2024
I think this caused profilebootstrap failure on x86_64-linux-gnu.
I notice the definition of GOT_ALIAS_SET for all non mingw targets is
now just -1. That seems very wrong to me.
It was originally:
```
alias_set_type
x86_GOT_alias_set (void)
{
static alias_set_type set = -1;
if (set == -1)
set = new_alias_set ();
return set;
}
```
And GOT_ALIAS_SET is used in more than COFF areas. Can you please fix
this definition?
Thanks,
Andrew Pinski
>
> Regards,
> Evgeny
>
> Evgeny Karpov (6):
> Move mingw_* declarations to the mingw folder
> Extract ix86 dllimport implementation to mingw
> Rename functions for reuse in AArch64
> aarch64: Add selectany attribute handling
> Adjust DLL import/export implementation for AArch64
> aarch64: Add DLL import/export to AArch64 target
>
> gcc/config.gcc | 20 ++-
> gcc/config/aarch64/aarch64-protos.h | 5 -
> gcc/config/aarch64/aarch64.cc | 42 ++++-
> gcc/config/aarch64/cygming.h | 33 +++-
> gcc/config/i386/cygming.h | 16 +-
> gcc/config/i386/i386-expand.cc | 4 +-
> gcc/config/i386/i386-expand.h | 2 -
> gcc/config/i386/i386-protos.h | 10 --
> gcc/config/i386/i386.cc | 205 ++----------------------
> gcc/config/i386/i386.h | 2 +
> gcc/config/mingw/mingw32.h | 2 +-
> gcc/config/mingw/t-cygming | 6 +
> gcc/config/mingw/winnt-dll.cc | 231 ++++++++++++++++++++++++++++
> gcc/config/mingw/winnt-dll.h | 30 ++++
> gcc/config/mingw/winnt.cc | 10 +-
> gcc/config/mingw/winnt.h | 38 +++++
> 16 files changed, 423 insertions(+), 233 deletions(-)
> create mode 100644 gcc/config/mingw/winnt-dll.cc
> create mode 100644 gcc/config/mingw/winnt-dll.h
> create mode 100644 gcc/config/mingw/winnt.h
>
> --
> 2.25.1
>
