On Thu, Jul 11, 2024 at 4:18 PM Andrew Pinski <pins...@gmail.com> wrote: > > On Thu, Jul 11, 2024 at 4:14 PM Ian Lance Taylor <i...@golang.org> wrote: > > > > The libbacktrace testsuite was not passing when run with current > > versions of clang. Add the optnone attribute to make it pass. Add > > -Wno-attributes and -Wno-unknown-attributes to disable warnings about > > unrecognized function attributes. Bootstrapped and ran libbacktrace > > testsuite on x86_64-pc-linux-gnu. Committed to mainline. > > NoteI see they have `noclone` and `noinline`, maybe it should have > `noipa` on them too. noipa disables a few more things than > noclone/noinline that might make a difference too.
Thanks, I looked into that, and as far as I can tell for purposes of the libbacktrace testsuite it doesn't matter. All that matters here is that the function isn't inlined, so that it shows up in the call stack. It's OK if the compiler makes other deductions about what the function does. And indeed the tests are passing. Of course we can change the testsuite again if I'm mistaken. Ian
