On Tue, Jul 30, 2024 at 12:22:01PM +0200, Richard Biener wrote:
> On Mon, Jul 29, 2024 at 5:15 PM Alejandro Colomar <a...@kernel.org> wrote:
> >
> > The old name was misleading.
> >
> > While at it, also rename some temporary variables that are used with
> > this function, for consistency.
> >
> > Link:
> > https://inbox.sourceware.org/gcc-patches/9fffd80-dca-2c7e-14b-6c9b509a7...@redhat.com/T/#m2f661c67c8f7b2c405c8c7fc3152dd85dc729120
> > Cc: Gabriel Ravier <gabrav...@gmail.com>
> > Cc: Martin Uecker <uec...@tugraz.at>
> > Cc: Joseph Myers <josmy...@redhat.com>
> > Cc: Xavier Del Campo Romero <xavi....@tutanota.com>
> >
> > gcc/ChangeLog:
> >
> > * tree.cc (array_type_nelts): Rename function ...
> > (array_type_nelts_minus_one): ... to this name. The old name
> > was misleading.
> > * tree.h: Likewise.
> > * c/c-decl.cc: Likewise.
> > * c/c-fold.cc: Likewise.
>
> This and the cp/ and fortran/ and rust/ entries below have different ChangeLog
> files and thus need not be prefixed but need
>
> gcc/cp/ChangeLog:
>
> etc.
And not just that, but shouldn't also start with Likewise. in each of those
ChangeLogs because the context isn't there, so need to repeat what changed.
Also, generally, we specify what exact functions/macros/etc. have been
changed, not just what files (unless it would be too large, hundreds or
thousands of changes, which is not the case here).
Jakub
