Hi Jonathan, > On Wed, 31 Jul 2024 at 13:27, Jonathan Wakely <jwak...@redhat.com> wrote: >> >> I doubt we want the @euro suffix anywhere except Glibc-based targets. We >> certainly don't want to append "@euro" on Solaris, where this change >> flips some tests from UNSUPPORTED to PASS, e.g. >> 21_strings/basic_string/numeric_conversions/char/to_string_float.cc >> It will probably also cause some to flip from UNSUPPORTED to FAIL, which >> we'll need to address. > > Oh, I've just realised that the UNSUPPORTED -> PASS I observed on > Solaris was a build using my patch for PR 57585, which is not pushed > yet. I think without that all uses of dg-require-namedlocale might > fail on Solaris, so this change won't actually change anything ... > yet. > > It still seems worth doing now though.
agreed: while Solaris 11.4 does have a few *.ISO8859-15@euro locales da_DK.ISO8859-15@euro en_GB.ISO8859-15@euro en_US.ISO8859-15@euro sv_SE.ISO8859-15@euro the majority (17) are not. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University