On Jun 27, 2012, Christophe Lyon <christophe.l...@st.com> wrote: >> I looked at the patch in there, and I'm afraid I don't understand how it >> achieves the ChangeLog-suggested purpose of ensuring -O2 makes to >> C*FLAGS_FOR_TARGET, when all it appears to do is to prepend -g. Can you >> please clarify?
> With more context, the current code fragment is: > CFLAGS_FOR_TARGET=$CFLAGS > case " $CFLAGS " in > *" -O2 "*) ;; > *) CFLAGS_FOR_TARGET="-O2 $CFLAGS" ;; > esac > case " $CFLAGS " in > *" -g "* | *" -g3 "*) ;; > *) CFLAGS_FOR_TARGET="-g $CFLAGS" ;; > esac > where pre-pending -g discards -O2 if it was pre-pended just above. I see, thanks for clarifying. I suggest changing both occurrences of $CFLAGS within the case statements, then; the more uniform logic is more appealing to me. Patch approved with these changes. Thanks, -- Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/ You must be the change you wish to see in the world. -- Gandhi Be Free! -- http://FSFLA.org/ FSF Latin America board member Free Software Evangelist Red Hat Brazil Compiler Engineer