On Thu, 28 Jun 2012, Maciej W. Rozycki wrote:

>       * config/mips/sfp-machine.h: New file.
>       * config.host <mips*-sde-elf*>: Enable soft-fp.

The compiler uses MIPS NaN conventions on MIPS; fp-bit knows about those 
but soft-fp does not.  Are you not concerned about that regression?  (Is 
this code only ever going to be used in software floating-point 
configurations, without exception support, so the choice of NaN doesn't 
matter much?)

libgcc/config/mips/t-mips sets FPBIT and DPBIT.  Shouldn't you do 
something to override those settings?  Even if the libgcc logic is to 
build soft-fp if both soft-fp and fp-bit are configured, it would seem 
cleaner for the fragments to configure only the relevant one.

-- 
Joseph S. Myers
jos...@codesourcery.com

Reply via email to