On Fri, 2024-08-30 at 12:08 +0100, Alex Coplan wrote:
> Hi,
>
> As it stands, the pretty printing of GCC's vecs by gdbhooks.py only
> handles vectors with vl_embed layout. As such, when encountering a
> vec
> with vl_ptr layout, GDB would print a diagnostic like:
>
> gdb.error: There is no member or method named m_vecpfx.
>
> when (e.g.) any such vec occurred in a backtrace. This patch extends
> VecPrinter.children to also handle vl_ptr vectors.
>
> Manually tested by verifying that vl_embed vectors still print
> correctly
> and empty vl_ptr vectors no longer trigger errors.
>
> OK for trunk?
Thanks for fixing this.
+ else:
+ assert False, f"unxpected vec kind {kind}"
Typo: "unxpected" -> "unexpected"
Otherwise, looks good for trunk (with a ChangeLog).
Thanks again
Dave
