> > (What's the right way to send a patch to fix a PR? I'm not even sure > > whether you were cc'ed on my response.) > > The right way to send a patch to fix a PR is to send it to gcc-patches ;)
Well, yeah, but in this case I was just proposing a patch for discussion, and using the bugzilla mechanism didn't seem to be working. I guess it's gcc-patches even for discussion. > > > You can't delay producing pubnames this way with LTO. Please fix. > > > > The obvious problem is that we're calling langhooks.dwarf_name (in > > gen_namespace_die) for an anonymous namespace, even with the default > > -gno-pubnames. I can fix that by adding a check for want_pubnames just > > before > > the call to add_pubname_string, as in the patch below. But this is still > > going > > That's sensible anyways - you avoid useless work. So the patch is ok. OK, I'll submit this patch, but leave the PR open and follow up with something to fix the underlying problem as you suggest. -cary
