On Wed, Jul 18, 2012 at 10:08 AM, Steven Bosscher <stevenb....@gmail.com> wrote: > On Wed, Jul 18, 2012 at 2:24 AM, H.J. Lu <hjl.to...@gmail.com> wrote: >> This caused: >> >> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54008 > > Yes, they failed in my testing, too. I must have been blind to overlook > them... > > I received some comments in private about the "new look" of the dumps, > that I'll be addressing with a patch later today. I'll fix these two > test cases with that patch also.
Hello, The attached patch further consolidates RTL and GIMPLE CFG dumping. It also fixes a couple of formatting issues, and it fixes the two broken test case patterns from yesterday's patch. I also ran into a bug in the GIMPLE CFG dumping hooks while working on value profiling cleanups (that have been oh so long on my TODO list...). It is necessary to flush the pretty-printer buffer to the dump file before printing directly to the pretty-printer stream with dump_histograms_for_stmt. For good measure, I replaced pp_newfile with pp_flush in places where that seemed to be more appropriate, and added comments to the functions that do _not_ flush the buffer (this can happen e.g. because a user of those functions wants to print additional information before the newline that pp_flush adds). Bootstrapped&tested on powerpc64-unknown-linux-gnu. This patch doesn't affect Graphite, so perhaps it won't break this time :-) OK for trunk? Ciao! Steven
cleanup_cfg_dump_2.diff
Description: Binary data
