On Mon, Jan 13, 2025 at 06:38:00PM +0000, Richard Sandiford wrote:
> In g:06c4cf398947b53b4bfc65752f9f879bb2d07924 I mishandled signed
> comparisons of comparison results on STORE_FLAG_VALUE < 0 targets
> (despite specifically referencing STORE_FLAG_VALUE in the commit
> message). There, (lt TRUE FALSE) is true, although (ltu FALSE TRUE)
> still holds.
>
> Things get messy with vector modes, and since those weren't the focus
> of the original commit, it seemed better to punt on them for now.
> However, punting means that this optimisation no longer feels like
> a natural tail-call operation. The patch therefore converts
> "return simplify..." to the usual call-and-conditional-return pattern.
>
> Bootstrapped & regression-tested on aarch64-linux-gnu. Also tested
> by build m68k-elf. OK to install?
>
> Richard
>
>
> gcc/
Missing
PR target/118418
here
> * simplify-rtx.cc (simplify_context::simplify_relational_operation_1):
> Take STORE_FLAG_VALUE into account when handling signed comparisons
> of comparison results.
Otherwise LGTM.
Jakub
