On Tue, Mar 11, 2025 at 02:24:26PM -0500, Robert Dubner wrote:
> As described in https://gcc.gnu.org/gitwrite.html, this is my inaugural,
> no-prior-approval-required, is-it-working? --yes-it-is-I-just-did-it patch
> to MAINTAINERS
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 84c0a6b892b..34e2f9f53b7 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -162,6 +162,7 @@ Ada front end           Arnaud Charlet
> <[email protected]>
>  Ada front end           Eric Botcazou
> <[email protected]>
>  Ada front end           Marc Poulhiès           <[email protected]>
>  Ada front end           Pierre-Marie de Rodat   <[email protected]>
> +COBOL front end         Robert Dubner           <[email protected]>
>  c++                     Jason Merrill           <[email protected]>
>  c++                     Nathan Sidwell          <[email protected]>
>  D front end             Iain Buclaw             <[email protected]>

You can't be a maintainer (the first hunk) and reviewer (second hunk) at the
same time.  The difference between maintainer and reviewer is that
maintainer can commit his own patches to the maintained subsystem without
review (doesn't mean he can't ask for review).
So, if the steering committee appointed you as maintainer, you should be
just in the first hunk, if as a reviewer, second hunk.
The third hunk is ok if you want all your commits go under DCO.

> @@ -276,6 +277,7 @@ check in changes outside of the parts of the compiler
> they maintain.
>  arm port (MVE)          Christophe Lyon         <[email protected]>
>  callgraph               Martin Jambor           <[email protected]>
>  C front end             Marek Polacek           <[email protected]>
> +COBOL front end         Robert Dubner           <[email protected]>
>  CTF, BTF                Indu Bhagat             <[email protected]>
>  CTF, BTF, bpf port      David Faust             <[email protected]>
>  dataflow                Paolo Bonzini           <[email protected]>
> @@ -445,6 +447,7 @@ Dimitar Dimitrov                dimitar
> <[email protected]>
>  Benoit Dupont de Dinechin       bd3
> <[email protected]>
>  Lehua Ding                      -               <[email protected]>
>  Ulrich Drepper                  drepper         <[email protected]>
> +Robert Dubner                   rdubner         <[email protected]>
>  François Dumont                 fdumont         <[email protected]>
>  Zdenek Dvorak                   rakdver         <[email protected]>
>  Michael Eager                   eager           <[email protected]>

        Jakub

Reply via email to