On 31/03/2025 20:04, Christophe Lyon wrote:
> Recent syntactic fixes enabled the test, but the result was failing.
>
> It turns out it was missing a space between the register arguments in
> the scan-assembler-times directives.
>
> gcc/testsuite/ChangeLog:
>
> PR target/119556
> * gcc.target/arm/short-vfp-1.c: Add missing spaces.
> ---
> gcc/testsuite/gcc.target/arm/short-vfp-1.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/gcc/testsuite/gcc.target/arm/short-vfp-1.c
> b/gcc/testsuite/gcc.target/arm/short-vfp-1.c
> index 18d38a58037..f6866c4f601 100644
> --- a/gcc/testsuite/gcc.target/arm/short-vfp-1.c
> +++ b/gcc/testsuite/gcc.target/arm/short-vfp-1.c
> @@ -1,5 +1,5 @@
> /* { dg-do compile } */
> -/* { dg-require-effective-target arm_vfp_ok }
> +/* { dg-require-effective-target arm_vfp_ok } */
> /* { dg-add-options arm_vfp } */
>
> int
> @@ -38,8 +38,8 @@ test_sihi (short x)
> return (int)x;
> }
>
> -/* { dg-final { scan-assembler-times {vcvt\.s32\.f32\ts[0-9]+,s[0-9]+} 2 } }
> */
> -/* { dg-final { scan-assembler-times {vcvt\.f32\.s32\ts[0-9]+,s[0-9]+} 2 } }
> */
> -/* { dg-final { scan-assembler-times {vmov\tr[0-9]+,s[0-9]+} 2 } } */
> -/* { dg-final { scan-assembler-times {vmov\ts[0-9]+,r[0-9]+} 2 } } */
> -/* { dg-final { scan-assembler-times {sxth\tr[0-9]+,r[0-9]+} 2 } } */
> +/* { dg-final { scan-assembler-times {vcvt\.s32\.f32\ts[0-9]+, s[0-9]+} 2 }
> } */
> +/* { dg-final { scan-assembler-times {vcvt\.f32\.s32\ts[0-9]+, s[0-9]+} 2 }
> } */
> +/* { dg-final { scan-assembler-times {vmov\tr[0-9]+, s[0-9]+} 2 } } */
> +/* { dg-final { scan-assembler-times {vmov\ts[0-9]+, r[0-9]+} 2 } } */
> +/* { dg-final { scan-assembler-times {sxth\tr[0-9]+, r[0-9]+} 2 } } */
OK.
Changes like this should be considered obvious, BTW.
R.