Paul-Antoine Arras wrote:
Thanks Sandra and Jakub for your comments.
Likewise thanks to them and to you for the patch.
Minor comments:
include/ChangeLog:
* gomp-constants.h (GOMP_DEVICE_DEFAULT_OMP_61): Define.
(GOMP_INTEROP_FLAG_TARGET): Define.
(GOMP_INTEROP_FLAG_TARGETSYNC): Define.
You also define GOMP_INTEROP_FLAG_NOWAIT - please add to the changelog.
(BTW: You can use a single '(...): Define.' for all of them.)
+/* Process the OpenMP interop directive. 'init' and 'destroy' take an array
+ of 'omp_interop_t *', 'use' an array of 'omp_interop_t', where
+ 'omp_interop_t' is internally 'struct interop_obj_t *';
+ 'flag' is used for the 'nowait' clause. */
+
+void
+GOMP_interop (int device_num, int n_init, struct interop_obj_t ***init,
+ const int *target_targetsync, const char **prefer_type, int n_use,
+ struct interop_obj_t **use, int n_destroy,
+ struct interop_obj_t ***destroy, unsigned int flags,
Can you use 'flags' not 'flag' in the comment for consistency?
Otherwise, it LGTM.
Thanks again!
Tobias
