On Mon, 12 May 2025 at 17:34, Jonathan Wakely <[email protected]> wrote: > > On Mon, 12 May 2025 at 16:46, Alejandro Colomar <[email protected]> wrote: > > > > contrib/ChangeLog: > > > > * gcc-changelog/git_commit.py (GitCommit): > > Add support for 'Link:' tags. > > > > Cc: Jason Merrill <[email protected]> > > I don't think we want a Cc: trailer in the actual commit message. do we? > > What is a Link: tag? I assume this is some kind of Git trailer, but > what for? A URL? Why do we need to use a Git trailer for that instead > of just putting the URL in the commit message body?
It seems to be one of the more common trailers used in the linux kernel [1], but this isn't the kernel. Why do you "need" it for GCC? We shouldn't be copying conventions from other projects just because that's how somebody else does things. What benefit is there to GCC to doing this, and requiring changes to our tools to support it? [1] https://www.reddit.com/r/git/comments/nl36wl/the_top_1_commit_trailers_of_gitgit/
