Hi Segher,
On 7/17/2025 10:20 PM, Segher Boessenkool wrote:
CAUTION: This email comes from a non Wind River email account!
Do not click links or open attachments unless you recognize the sender and know
the content is safe.
Hi!
On Thu, Jul 17, 2025 at 05:58:47AM -0700, harish.sadin...@windriver.com wrote:
From: Harish Sadineni <harish.sadin...@windriver.com>
Avoid encoding full build paths into file headers; use only the basename of the
source file.
Line way too long. Commit message lines are 72 character positions
wide.
(The semicolon should be a colon btw. Or just a full stop reads nicer
there).
This improves build reproducibility, particularly in environments where build
paths
vary or where source files are saved for debugging.
For example, in addkf3-sw.c, the file header previously contained the full
source path:
/* file created from ../../../libgcc/soft-fp/addtf3.c */
With this change, only the filename is included:
/* file created from addtf3.c */
Excellent, that example helps :-)
It also answers the next question "is there something else in the path
we would care about?": nope, it just says soft-fp, and that will be
clear from context anyway.
Okay for trunk (with the commit message improved). Thank you!
Thank you for the review.
I have updated the commit message as you suggested and sent a v3.
Do you want backports? Okay for those as well (if they are wanted).
In addition to master branch, I would like this change to be backported
to GCC 15 and GCC 14.
We're also using GCC 13 and GCC 12 would you prefer that I prepare
separate backport
patches for these branches, or will the backports be handled by maintainers?
Thanks,
Harish
Segher
