Hi Tomasz,
there's no time-pressure or rush from my side. We've finished the
C++23 parts of mdspan, I think that's the important milestone. Hence,
I feel it makes a lot of sense if you deprioritize reviewing mdspan
related patches for a while.
Personally, I think it would be least work for everyone to just prepare
clean patch series. I'll prepare them locally, send one for review. You
make sure you only review them when time permits. Then I refine until it
meets your expectations; and we let it rest until Jonathan can OK it.
If I feel like I have to many things ready locally (not particularly
likely), I'll work on making a robot balance, or something else that's
also fun :)
Thank you for the update!
Luc
On 7/22/25 12:06, Tomasz Kaminski wrote:
Hi,
These commits mostly LGTM, as mentioned, but as I have mentioned in other
emails,
They may stay as is for some time.
However, we could land a (test rewrite) patch soon, as it does not
introduce any functional changes,
so you could send a v2 of that, and then patch series with only functional
patches, but there
is no strong need for that.
On Mon, Jul 21, 2025 at 10:22 AM Luc Grosheintz <luc.groshei...@gmail.com>
wrote:
This is the second iteration of:
https://gcc.gnu.org/pipermail/libstdc++/2025-July/062315.html
These patches can be applied cleanly after the dims patch; but might
conflict if applied before.
The changes include:
- After discussion on the mailling list [1], the feature testing macro
for is_sufficiently_aligned was added to
20_util/headers/memory/version.cc
The 20_util tests were run with GLIBCXX_TESTSUITE_STDS=17,20,23,26.
- The features testing macro for aligned_accessor was added to
mdspan/version.cc
- The debug assertions for alignedness of the pointer passed to
access and offset were removed, but the tests were retained.
- Strengthen one test to check non-constructible (instead of not
convertible).
- Use the PR number in commits and this time sign-off on all of them
(sorry!).
[1]: https://gcc.gnu.org/pipermail/libstdc++/2025-July/062628.html
Luc Grosheintz (3):
libstdc++: Implement is_sufficiently_aligned [PR120994]
libstdc++: Prepare test code for default_accessor for reuse.
libstdc++: Implement aligned_accessor from mdspan [PR120994]
libstdc++-v3/include/bits/align.h | 16 ++
libstdc++-v3/include/bits/version.def | 18 ++
libstdc++-v3/include/bits/version.h | 20 +++
libstdc++-v3/include/std/mdspan | 68 +++++++
libstdc++-v3/include/std/memory | 1 +
libstdc++-v3/src/c++23/std.cc.in | 7 +-
.../20_util/headers/memory/version.cc | 5 +
.../20_util/is_sufficiently_aligned/1.cc | 31 ++++
.../23_containers/mdspan/accessors/aligned.cc | 43 +++++
.../mdspan/accessors/aligned_neg.cc | 33 ++++
.../accessors/debug/aligned_access_neg.cc | 23 +++
.../accessors/debug/aligned_offset_neg.cc | 23 +++
.../23_containers/mdspan/accessors/default.cc | 99 -----------
.../23_containers/mdspan/accessors/generic.cc | 168 ++++++++++++++++++
.../testsuite/23_containers/mdspan/version.cc | 8 +
15 files changed, 462 insertions(+), 101 deletions(-)
create mode 100644
libstdc++-v3/testsuite/20_util/is_sufficiently_aligned/1.cc
create mode 100644
libstdc++-v3/testsuite/23_containers/mdspan/accessors/aligned.cc
create mode 100644
libstdc++-v3/testsuite/23_containers/mdspan/accessors/aligned_neg.cc
create mode 100644
libstdc++-v3/testsuite/23_containers/mdspan/accessors/debug/aligned_access_neg.cc
create mode 100644
libstdc++-v3/testsuite/23_containers/mdspan/accessors/debug/aligned_offset_neg.cc
delete mode 100644
libstdc++-v3/testsuite/23_containers/mdspan/accessors/default.cc
create mode 100644
libstdc++-v3/testsuite/23_containers/mdspan/accessors/generic.cc
--
2.50.0
