Re: [PATCH v2 1/3] OpenMP: Improve front-end error-checking for "declare variant"

[Tobias Burnus]

Sandra Loosemore wrote:

This patch fixes a number of problems with parser error checking of
"declare variant", especially in the C front end.

...

gcc/c/ChangeLog
        * c-parser.cc (c_finish_omp_declare_variant): Rework diagnostic
        code.  Do not record variant if there are errors.  Make check for
        a missing "match" clause unconditional.

gcc/cp/ChangeLog
        * parser.cc (cp_finish_omp_declare_variant): Structure diagnostic
        code similarly to C front end.  Make check for a missing "match"
        clause unconditional.

gcc/fortran/ChangeLog
        * openmp.cc (gfc_match_omp_declare_variant): Make check for a
        missing "match" clause unconditional.

gcc/testsuite/ChangeLog
        * c-c++-common/gomp/append-args-1.c: Adjust expected output.
        * g++.dg/gomp/adjust-args-1.C: Likewise.
        * g++.dg/gomp/adjust-args-3.C: Likewise.
        * gcc.dg/gomp/adjust-args-1.c: Likewise:
        * gcc.dg/gomp/append-args-1.c: Likewise.
        * gcc.dg/gomp/unprototyped-variant.c: New.
        * gfortran.dg/gomp/adjust-args-1.f90: Adjust expected output.
        * gfortran.dg/gomp/append_args-1.f90: Likewise.

LGTM. Thanks for the patch

Tobias