On Fri, Aug 29, 2025 at 11:53:35PM -0700, Andrew Pinski wrote:
> > if (!TYPE_UNSIGNED (ty2) || !INTEGRAL_TYPE_P (ty2))
> > return false;
> > - if (TYPE_PRECISION (ty1) > TYPE_PRECISION (ty2))
> > + if (TYPE_PRECISION (ty2) != 8 || TYPE_PRECISION (ty1) < 8)
>
> Should 8 be BITS_PER_UNIT instead?
Nope. When it checks for -128 constant, then it needs to be exactly 8 bits.
If it checked for minimum of signed char type, it should be precision of
the char type. Not that it is any different on any of the supported targets.
Jakub
