> I've gone ahead and made these adjustments, and pushed the following: Really appreciate for that! I'll stick to this convention in the future.
BTW, I don't have write access to the repository, so I could not push this commit after this patch gets approved. On 2025/8/30 03:52, Jason Merrill wrote: > On 8/28/25 12:33 PM, Sirui Mu wrote: >> Hello, >> >> This is the 2nd version of the patch. Changes made since the initial version: >> - Implemented Jason's suggestions, move the declaration of first down. >> - Add signed-off-by to the commit. > > Please preserve the rationale in later revisions of the patch; revision notes > can go at the top, followed by a scissors line (-- 8< --), then the commit > message. > > Please wrap lines in the commit message at 76 columns so that they still fit > in 80 columns with the 4 spaces of left padding from 'git log'. The subject > line should be even shorter; I aim for 50 characters after "[PATCH] ", but > this isn't a strict rule. > > The commit message also needs ChangeLog entries; git gcc-commit-mklog > automates most of that. > > This time, I've gone ahead and made these adjustments, and pushed the > following: > > Thanks again.
