On Mon, Oct 13, 2025 at 10:06:29AM +0200, Jakub Jelinek wrote:
> On Fri, Oct 10, 2025 at 01:59:54PM +0200, Christophe Lyon wrote:
> > We've noticed a regression (on aarch64):
> > Running g++:g++.dg/gomp/gomp.exp ...
> > FAIL: c-c++-common/gomp/append-args-7.c -std=c++26
> > scan-tree-dump-times gimple "f3 \\(obj1, obj2, 1, a, cp, d\\);" 1
> > FAIL: c-c++-common/gomp/append-args-7.c -std=c++26 (test for excess errors)
>
> Sorry, seems I've missed this.
>
> Since my recent patch, GCC for C++26 uses the TYPE_NO_NAMED_ARGS_STDARG_P
> flag like C23 uses for (...) function types. The OpenMP declare variant
> append_args handling does some very ugly hacks (modify TYPE_ARG_TYPES
> temporarily instead of trying to create new function types) and had
> to be tweaked to deal with that. This fixes
> -FAIL: c-c++-common/gomp/append-args-7.c -std=c++26 scan-tree-dump-times
> gimple "f3 \\\\(obj1, obj2, 1, a, cp, d\\\\);" 1
> -FAIL: c-c++-common/gomp/append-args-7.c -std=c++26 (test for excess errors)
>
> Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for
> trunk?
I mean, committed to trunk, sorry.
Jakub