On Wed, Oct 22, 2025 at 8:59 PM Uros Bizjak <[email protected]> wrote:
>
> On Wed, Oct 22, 2025 at 1:55 PM H.J. Lu <[email protected]> wrote:
> >
> > Use HOST_WIDE_INT_M1U, instead of -1, to initialize unsigned HOST_WIDE_INT.
> >
> > * config/i386/i386-expand.cc (ix86_expand_set_or_cpymem): Use
> > HOST_WIDE_INT_M1U to initialize unsigned HOST_WIDE_INT.
> >
> > OK for master?
>
>    unsigned HOST_WIDE_INT min_size = 0;
> -  unsigned HOST_WIDE_INT max_size = -1;
> -  unsigned HOST_WIDE_INT probable_max_size = -1;
> +  unsigned HOST_WIDE_INT max_size = HOST_WIDE_INT_M1U;
> +  unsigned HOST_WIDE_INT probable_max_size = HOST_WIDE_INT_M1U;
>
> For consistency, you can use HOST_WIDE_INT_0U for min_size as well.
>
> OK with the above addition.
>
> Thanks,
> Uros.

This is the patch I am checking in.

Thanks.

-- 
H.J.
From f4f3cdf6516d470c5c70a271ae44bcf24910759b Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <[email protected]>
Date: Wed, 22 Oct 2025 19:46:58 +0800
Subject: [PATCH] x86: Use HOST_WIDE_INT_(0|M1)U to initialize unsigned
 HOST_WIDE_INT

Use HOST_WIDE_INT_0U, instead of 0, HOST_WIDE_INT_M1U, instead of -1, to
initialize unsigned HOST_WIDE_INT.

	* config/i386/i386-expand.cc (ix86_expand_set_or_cpymem): Use
	HOST_WIDE_INT_0U and HOST_WIDE_INT_M1U to initialize unsigned
	HOST_WIDE_INT.

Signed-off-by: H.J. Lu <[email protected]>
---
 gcc/config/i386/i386-expand.cc | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gcc/config/i386/i386-expand.cc b/gcc/config/i386/i386-expand.cc
index 5bcc35c8144..a1f1b26f78a 100644
--- a/gcc/config/i386/i386-expand.cc
+++ b/gcc/config/i386/i386-expand.cc
@@ -9515,9 +9515,9 @@ ix86_expand_set_or_cpymem (rtx dst, rtx src, rtx count_exp, rtx val_exp,
   machine_mode move_mode = VOIDmode;
   int unroll_factor = 1;
   /* TODO: Once value ranges are available, fill in proper data.  */
-  unsigned HOST_WIDE_INT min_size = 0;
-  unsigned HOST_WIDE_INT max_size = -1;
-  unsigned HOST_WIDE_INT probable_max_size = -1;
+  unsigned HOST_WIDE_INT min_size = HOST_WIDE_INT_0U;
+  unsigned HOST_WIDE_INT max_size = HOST_WIDE_INT_M1U;
+  unsigned HOST_WIDE_INT probable_max_size = HOST_WIDE_INT_M1U;
   bool misaligned_prologue_used = false;
   addr_space_t dst_as, src_as = ADDR_SPACE_GENERIC;
 
-- 
2.51.0

Reply via email to