Updated ACK table: [x] target-independent bits [ ] alpha [x] arm [ ] avr [ ] bfin [ ] cr16 [x] cris [x] epiphany [ ] i386 [ ] ia64 [x] iq2000 [ ] lm32 [ ] m32c [x] m32r [x] mcore [ ] mep [x] microblaze [x] mips [x] mmix [x] mn10300 [ ] pa [x] rs6000 [x] rx [ ] s390 [ ] score [x] sh [ ] sparc [x] spu [x] stormy16 [x] v850 [ ] vax [ ] xtensa
On Tue, 2012-09-04 at 21:33 -0400, Hans-Peter Nilsson wrote: > It helps if you CC port maintainers where approval is requested; > you missed at least me. Right. Did that for the remaining targets. (BTW, there's no maintainer listed for the cr16 port) For the reference, the current version of the patch is here: http://gcc.gnu.org/ml/gcc-patches/2012-09/msg00210.html > Still, considering that we're C++ now, you can presumably drop > the function parameter name instead of adding ATTRIBUTE_UNUSED. Yes, that has been mentioned before and I did drop the parameter names in a place or two, but not in the target pieces -- on purpose. Personally I prefer reading 'int bleh ATTRIBUTE_UNUSED' instead of 'int,int,bool,char,int,void*'. Makes it somehow easier to follow and/or fill in the blanks. > PS. please consider building cc1 for each target using > contrib/config-list.mk or a similar script, to eliminate > breaking typos. Thanks for the hint! Cheers, Oleg
