> I just repeated the build and test - there are no warnings and/or erorrs > about __sig. There are likewise no warnings or errors about it in either > the Acats or the gnat testsuite logs. The build completes normally as does > the testsuite. > > The new file is correctly linked as far as I can tell.
Yes, to our surprise, the no-underscore-at-start-of-identifiers Ada rule is not enforced in internal units (i.e. units of the run-time library). But the underscores look nevertheless a bit strange so I'd remove them and use sig. > If the change is not being taken into account, then some other property is > causing > 120 tests to run correctly where they were previously failing > (and that is the only change in the Ada tree). > > === acats Summary === > # of expected passes 2578 > # of unexpected failures 0 > Native configuration is i686-apple-darwin9 > > [...] > > I’m not sure how to proceed at the moment - I can easily make the > typographical changes (to the header and the symbol name) - but not sure > how to test that I’ve “fixed” something, I think that your testing procedure is fine, so you can make the changes, recompile and commit the result. Thanks again for working on this! -- Eric Botcazou
